[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Bug fix for LVM
From: |
Felix Zielcke |
Subject: |
Re: [PATCH] Bug fix for LVM |
Date: |
Tue, 28 Jul 2009 23:37:13 +0200 |
Am Dienstag, den 28.07.2009, 19:42 +0200 schrieb Robert Millan:
> On Tue, Jul 28, 2009 at 11:15:09PM +0800, Bean wrote:
>
> > +static int
> > +probe_raid_level (grub_disk_t disk)
> > +{
> > + if (disk->dev->id != GRUB_DISK_DEVICE_RAID_ID)
> > + return -1;
> > +
> > + return ((struct grub_raid_array *) disk->data)->level;
> > +}
>
> Since this an ad-hoc function, could you put it in the same block that
> needs it? If 'static' qualifier is present, it won't result in nested
> function AFAICT.
>
GCC manual [0] says:
A nested function always has no linkage. Declaring one with extern or
static is erroneous.
[0]
http://gcc.gnu.org/onlinedocs/gcc-4.4.1/gcc/Nested-Functions.html#Nested-Functions
--
Felix Zielcke
Proud Debian Maintainer
- Re: [PATCH] Bug fix for LVM, (continued)
- Re: [PATCH] Bug fix for LVM, Patrik Horník, 2009/07/19
- Re: [PATCH] Bug fix for LVM, Bean, 2009/07/19
- Re: [PATCH] Bug fix for LVM, Felix Zielcke, 2009/07/25
- Re: [PATCH] Bug fix for LVM, Patrik Horník, 2009/07/27
- Re: [PATCH] Bug fix for LVM, Bean, 2009/07/27
- Re: [PATCH] Bug fix for LVM, Bean, 2009/07/28
- Re: [PATCH] Bug fix for LVM, Bean, 2009/07/28
- Re: [PATCH] Bug fix for LVM, Bean, 2009/07/28
- Re: [PATCH] Bug fix for LVM, Robert Millan, 2009/07/28
- Re: [PATCH] Bug fix for LVM,
Felix Zielcke <=
- Re: [PATCH] Bug fix for LVM, Bean, 2009/07/28
- Re: [PATCH] Bug fix for LVM, Robert Millan, 2009/07/31
- Re: [PATCH] Bug fix for LVM, Patrik Horník, 2009/07/30
- Re: [PATCH] Bug fix for LVM, Pavel Roskin, 2009/07/31
- Re: [PATCH] Bug fix for LVM, Bean, 2009/07/31
- Re: [PATCH] Bug fix for LVM, Felix Zielcke, 2009/07/31