Re: [PATCH] ntldr support

[Robert Millan]

On Sat, Aug 08, 2009 at 11:57:48PM +0200, Christian Franke wrote:
> Vladimir 'phcoder' Serbinenko wrote:
>>> About the command, i think that it will be simpler for the user if we have
>>> only one command: chainloader (like in grub4dos) that will try to detect the
>>> type of the bootloader. This is only my personal opinion.
>>>     
>> I don't agree with this. chainloader and ntldr don't share the same
>> syntax: chainloader expects a bootsector whereas ntldr expects an
>> ntldr ot bootmgr file. GRUB2 is done to break with bad design
>> decisions of GRUB1 one of them being "kernel" command. GRUB4DOS
>> follows GRUB1 on this subject.
>>   
>
> I agree.

Alright.  Let's make it a separate command.  I think it should still share
code with chainloader.c though (with some ifdefs).

I'll sort this out and make a newer patch when I find a free minute.

> It probably would make sense that the 'ntldr' command does simple  
> signature checks and fail on unknown files unless '--force' is specified.

You mean checking for the PE signature?  Yes, this would be nice too.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."