Re: [PATCH] Improve handling of "keep" in gfxpayload

[Vladimir 'phcoder' Serbinenko]

> This doesn't quite work perfectly yet. It's better than before - I've
> tested this, and if everything works properly then the result is a
> smooth zero-flicker transition, which is wonderful. However, if
> something goes wrong before the kernel starts a framebuffer then it has
> no way to display any text at all, and it doesn't seem to start one
> until relatively late for me. It may be that the next step here is to
> try to explicitly tell the kernel to set the correct VESA mode rather
> than using 0x0F04, but I thought I'd send this patch anyway in the
> meantime ...
What is the linux behaviour with 0x0F04? Does it just keep the mode?
What if the same mode is passed as a value? Does linux redoes the
modesetting? If 0x0F04 works ok I would prefer to always pass it when
kernel is booted in graphical mode. VESA mode numbers are an artifact
and when grub2 has its own graphical drivers it won't correspond to
anything.
>
> 2009-08-10  Colin Watson  <address@hidden>
>
>        * include/grub/i386/linux.h (GRUB_LINUX_VID_MODE_CURRENT): New
>        macro.
>        * loader/i386/linux.c (grub_linux_boot): If gfxpayload starts
>        with "keep", or if GRUB_ASSUME_LINUX_HAS_FB_SUPPORT is defined,
>        then set the vid_mode boot parameter to
>        GRUB_LINUX_VID_MODE_CURRENT.
>
> Thanks,
>
> --
> Colin Watson                                       address@hidden
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git