Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

[Vladimir 'phcoder' Serbinenko]

> This is based on previous work in GRUB Legacy by Kristian and Peter
> (CCed). Peter tells me that Red Hat has an assignment already on file,
> and it looks like mine is finally making some progress ...
We would need RedHat and Kristian to sign some papers.

Constants are i386-pc specific. In particular left and right shift are
distinguished but not ctrl or alt. We should either distinguish them
all or none.
Going to real mode to retrieve keyboard status is absolutely
unnecessary: same info is available in BDA. Perhaps our console driver
should switch to BDA altogether but I'm not sure that this will work
since grub2 disables interrupts (tests needed) but it definitly works
with keyboard status. Driver should return a consistent value even if
it doesn't support asynchronous query unless driver ignores modifier
keys altogether (EFI, sigh) or has no way to know if they are pressed
unless they are pressed together with another key. In the case of
at_keyboard it specifically means to return at_keyboard_status
transformed to correct format.
>
> Thanks,
>
> --
> Colin Watson                                       address@hidden
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git