[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/18] define asm constant for absolute memory access
From: |
Pavel Roskin |
Subject: |
Re: [PATCH 6/18] define asm constant for absolute memory access |
Date: |
Thu, 13 Aug 2009 01:03:34 -0400 |
On Tue, 2009-06-16 at 12:49 +0200, Vladimir 'phcoder' Serbinenko wrote:
> > +#ifdef APPLE_CC
> > + movl $(mmaphook_mmap_rel), %esi
> > +#else
> > movw $(DS(mmaphook_mmap)), %si
> > +#endif
>
> That's not an equivalent replacement. The argument width is
> different.
> I know. Sometimes because of the quirks I had to replace some code
> with a less logical alternative which should however work in the flow
Please don't commit such changes without an explicit permissions form
the maintainers. It's very time consuming to verify such code after it
has been committed.
--
Regards,
Pavel Roskin
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 6/18] define asm constant for absolute memory access,
Pavel Roskin <=