grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] RFT: Rename local labels with a macro from boot/i386/pc/boot


From: Pavel Roskin
Subject: Re: [PATCH] RFT: Rename local labels with a macro from boot/i386/pc/boot.S
Date: Thu, 13 Aug 2009 02:13:32 -0400

On Mon, 2009-08-10 at 13:29 +0200, Robert Millan wrote:
> On Sat, Aug 08, 2009 at 04:48:32PM +0200, Yves Blusseau wrote:
> > diff --git a/include/grub/symbol.h b/include/grub/symbol.h
> > index 68d9f00..5fba549 100644
> > --- a/include/grub/symbol.h
> > +++ b/include/grub/symbol.h
> > @@ -21,6 +21,8 @@
> >  
> >  #include <config.h>
> >  
> > +#define LOCAL(X)   L_##X
> > +
> >  /* Add an underscore to a C symbol in assembler code if needed. */
> >  #ifdef HAVE_ASM_USCORE
> >  # define EXT_C(sym)        _ ## sym

I changed LOCAL to be more similar to EXT_C (macro arguments don't
normally use capital letters).  I also added a comment, as there is no
other way to know why we are adding "L_" to the labels.

> Assuming Pavel is OK with it, I have no objection.

Committed.  Thank you!

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]