Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

[Vladimir 'phcoder' Serbinenko]

On Mon, Aug 24, 2009 at 1:57 PM, Robert Millan<address@hidden> wrote:
> On Mon, Aug 24, 2009 at 10:11:10AM +0100, Colin Watson wrote:
>> > But in at_keyboard it's definitely possible (check how we handle e.g. CTRL
>> > or SHIFT keys).
>>
>> No, that code only spots make scan codes arriving after GRUB's terminal
>> starts up. AFAICS it has no way to tell whether e.g. Shift was held down
>> already when GRUB started
>
> Ah, you're right on this..
>
In this particular case yes. But I can imagine other cases when it
doesn't matter. E.g. if a distro wants to show a notice before booting
single user entry and user wants to press shift to bypass this notice.
>> (except through the vagaries of key repeat),
>
> ..but on this too.  Why not check for key repeat?  The controller generates
> them for all keys AFAIK.
>
> --
> Robert Millan
>
>  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
>  how) you may access your data; but nobody's threatening your freedom: we
>  still allow you to remove your data and not access it at all."
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git