[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATC] Unit testing framework adjusted over trunk
From: |
BVK Chaitanya |
Subject: |
Re: [PATC] Unit testing framework adjusted over trunk |
Date: |
Sun, 10 Jan 2010 11:27:47 +0530 |
Some minor comments:
+
+if ! diff -q ${outfile1} ${outfile2} >/dev/null
+then
+ echo "$1: GRUB and BASH outputs (${outfile1}, ${outfile2}) did not match"
+ status=1
+else
+ rm -f ${outfile1} ${outfile2}
+fi
+
1. In the above echo statement, $1 doesn't resolve to the testcase
file name, use ${source} instead.
2. Change the "(${outfile1}, ${outfile2})" to "(see diff -u
${outfile1} ${outfile2})" so that developer can select-n-paste the
command more easily.
--
bvk.chaitanya