grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix a special case when accessing partition on linux


From: Bruce Dubbs
Subject: Re: [PATCH] Fix a special case when accessing partition on linux
Date: Sun, 31 Jan 2010 14:22:50 -0600
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.16) Gecko/20080722 SeaMonkey/1.1.11

Vladimir 'φ-coder/phcoder' Serbinenko wrote:
Because of cache coherency problem grub accesses partitions on linux by
hdaX device and not by hda with correct offset. The problem is that
because of 4K cache blocks disk.c may read sectors before the partition
and hence making hostdisk.c try to read from negative offset. I'm sad
that we need such workarounds for free systems.

I would think it beneficial for long term code maintenance to put
the above comments into the code itself.

// Because of a cache coherency problem grub accesses partitions
// on linux by an hdaX device and not by hda with the correct offset.
// The problem is that because of 4K cache blocks, disk.c may
// read sectors before the partition and hence make
// hostdisk.c try to read from a  negative offset.

  -- Bruce




reply via email to

[Prev in Thread] Current Thread [Next in Thread]