[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Which partitioning schemes should be supported by GRUB?
From: |
Colin Watson |
Subject: |
Re: Which partitioning schemes should be supported by GRUB? |
Date: |
Mon, 14 Jun 2010 18:33:02 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Jun 14, 2010 at 09:55:09AM -0700, Seth Goldberg wrote:
>>>> === modified file 'kern/i386/pc/init.c'
>>>> --- kern/i386/pc/init.c 2010-05-21 18:08:48 +0000
>>>> +++ kern/i386/pc/init.c 2010-06-14 14:44:13 +0000
>>>> @@ -83,6 +83,14 @@ make_install_device (void)
>>>> grub_snprintf (ptr, sizeof (dev) - (ptr - dev), ")%s", grub_prefix);
>>>> grub_strcpy (grub_prefix, dev);
>>>> }
>>>> + else if (grub_prefix[1] == ',')
>>>> + {
>>>> + /* We have a prefix, but still need to fill in the boot drive. */
>>>> + grub_snprintf (dev, sizeof (dev),
>>>> + "(%cd%u%s", (grub_boot_drive & 0x80) ? 'h' : 'f',
>>>> + grub_boot_drive & 0x7f, grub_prefix + 1);
>>>> + grub_strcpy (grub_prefix, dev);
>>>> + }
>
> What about CD devices? Seems like you're limiting to hd and fd here
> (though CD may just be an alias for hd198 or something like that). Just
> checking :).
That part of my patch was just copied from immediately above, so doesn't
really change the current state.
grub-mkrescue has special code for dealing with CDs and setting an
appropriate prefix at run-time from the output of a 'search' command.
--
Colin Watson address@hidden
- Re: Which partitioning schemes should be supported by GRUB?, (continued)
- Re: Which partitioning schemes should be supported by GRUB?, Grégoire Sutre, 2010/06/12
- Re: Which partitioning schemes should be supported by GRUB?, Vladimir 'φ-coder/phcoder' Serbinenko, 2010/06/12
- Re: Which partitioning schemes should be supported by GRUB?, Grégoire Sutre, 2010/06/13
- Re: Which partitioning schemes should be supported by GRUB?, Colin Watson, 2010/06/14
- Re: Which partitioning schemes should be supported by GRUB?, address@hidden, 2010/06/14
- Re: Which partitioning schemes should be supported by GRUB?, Colin Watson, 2010/06/14
- Re: Which partitioning schemes should be supported by GRUB?, Colin Watson, 2010/06/14
- Re: Which partitioning schemes should be supported by GRUB?, Vladimir 'φ-coder/phcoder' Serbinenko, 2010/06/14
- Re: Which partitioning schemes should be supported by GRUB?, Colin Watson, 2010/06/14
- Re: Which partitioning schemes should be supported by GRUB?, Seth Goldberg, 2010/06/14
- Re: Which partitioning schemes should be supported by GRUB?,
Colin Watson <=
- Re: Which partitioning schemes should be supported by GRUB?, Grégoire Sutre, 2010/06/14
- Re: Which partitioning schemes should be supported by GRUB?, Colin Watson, 2010/06/15
- Re: Which partitioning schemes should be supported by GRUB?, Grégoire Sutre, 2010/06/15
- Re: Which partitioning schemes should be supported by GRUB?, Colin Watson, 2010/06/16
- Re: Which partitioning schemes should be supported by GRUB?, Grégoire Sutre, 2010/06/16
- Re: Which partitioning schemes should be supported by GRUB?, Vladimir 'φ-coder/phcoder' Serbinenko, 2010/06/16
- Re: Which partitioning schemes should be supported by GRUB?, Colin Watson, 2010/06/17