[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix root device detection for lvm2
|
From: |
Colin Watson |
|
Subject: |
Re: [PATCH] Fix root device detection for lvm2 |
|
Date: |
Fri, 2 Jul 2010 12:34:31 +0100 |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Fri, Jul 02, 2010 at 01:44:21AM +0200, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> On 07/02/2010 01:32 AM, Colin Watson wrote:
> > The changes seem to have been to simplify the test to:
> >
> > [ "x`grub-probe -t abstraction --device ${GRUB_DEVICE}`" = "xlvm" ]
> >
> > Unfortunately this is an incorrect simplification. grub-probe can print
> > multiple abstractions, and does in the case of e.g. LVM on RAID. If it
> > is correct to avoid UUIDs for plain LVM, it is also correct to avoid
> > them for LVM on RAID.
>
> Ok I agree. The problem with original patch was that it would accept
> ttttlvmuuu too. Feel free to fix.
Fair enough. Done (r2503).
--
Colin Watson address@hidden