grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix stuck down arrow in menu entry editor


From: Andrey Borzenkov
Subject: [PATCH] Fix stuck down arrow in menu entry editor
Date: Tue, 19 Feb 2013 20:17:45 +0400

Variable `off' was never incremented so down arrow was always
printed, even when we have scrolled to the end of entry.

Signed-off-by: Andrey Borzenkov <address@hidden>

---
 ChangeLog                     |    5 +++++
 grub-core/normal/menu_entry.c |    3 +--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 654ebcb..349ca7d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2013-02-19  Andrey Borzenkov <address@hidden>
+
+       * grub-core/normal/menu_entry.c (update_screen): remove
+       unused variable `off' which caused scroll down arrow to be always shown.
+
 2013-02-19  Paulo Flabiano Smorigo <address@hidden>
 
        Support Openfirmware disks with non-512B sectors.
diff --git a/grub-core/normal/menu_entry.c b/grub-core/normal/menu_entry.c
index 7cd67f3..fbe360c 100644
--- a/grub-core/normal/menu_entry.c
+++ b/grub-core/normal/menu_entry.c
@@ -243,7 +243,6 @@ update_screen (struct screen *screen, struct 
per_term_screen *term_screen,
 
       do
        {
-         int off = 0;
          struct grub_term_pos **pos;
 
          if (linep >= screen->lines + screen->num_lines)
@@ -301,7 +300,7 @@ update_screen (struct screen *screen, struct 
per_term_screen *term_screen,
          y += get_logical_num_lines (linep, term_screen);
          if (y >= term_screen->num_entries)
            {
-             if (off <= linep->len || i + 1 < screen->num_lines)
+             if (i + 1 < screen->num_lines)
                down_flag = 1;
            }
 
-- 
tg: (cc35b49..) fu/stuck-down-arrow (depends on: master)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]