[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Initialized initrd_ctx so we don't free a random pointer fro
|
From: |
Andrei Borzenkov |
|
Subject: |
Re: [PATCH] Initialized initrd_ctx so we don't free a random pointer from the stack. |
|
Date: |
Sun, 21 Sep 2014 10:39:40 +0400 |
В Wed, 17 Sep 2014 16:30:11 -0400
Peter Jones <address@hidden> пишет:
> Currently, if "linux" fails, the "goto fail;" in grub_cmd_initrd sends us
> into grub_initrd_close() without grub_initrd_init() being called, and thus
> it never clears initrd_ctx->components. grub_initrd_close() then frees that
> address, which is stale data from the stack. If the stack happens to have a
> stale *address* there that matches a recent allocation, then you'll get a
> double free later.
>
> So initialize the memory up front.
>
Pushed.