grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: How can I submit patch for bug #42944 ?


From: Andrei Borzenkov
Subject: Re: How can I submit patch for bug #42944 ?
Date: Sun, 12 Oct 2014 20:24:25 +0400

В Sat, 11 Oct 2014 12:58:29 +0400
Andrei Borzenkov <address@hidden> пишет:

> В Sat, 11 Oct 2014 10:44:20 +0200
> Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
> 
> > On 10.10.2014 23:23, Colin Watson wrote:
> > > On Fri, Oct 10, 2014 at 04:44:39PM +0000, Rigoberto Corujo wrote:
> > >> I attached a patch to bug #42944 and would like to know how I would go 
> > >> about getting it committed to the source tree?
> > >> https://savannah.gnu.org/bugs/?42944
> > > 
> > > I'd suggest attaching the patch to a mail here (not encased in a zip
> > > file).  It's usually easier to get public review that way.
> > > 
> > I don't like to use EFI timers if we can avoid them, they've been known
> > to hang. Attached is a patch to use pmtimer for calibration
> 
> What about systems without ACPI? Does it explicitly exclude them?

OK, I stay corrected. Still, this patch adds over 1K to kernel on
i386-pc and about 0.5K to common core.img with ext2:

-rw-r--r-- 1 bor bor 26848 Oct 12 20:09 /tmp/core.img-pmtimer
-rw-r--r-- 1 bor bor 26320 Oct 12 18:50 /tmp/core.img-vanilla
-rwxr-xr-x 1 bor bor 29224 Oct 12 20:08 /tmp/kernel.img-pmtimer
-rwxr-xr-x 1 bor bor 28060 Oct 12 10:12 /tmp/kernel.img-vanilla

I think it's too much for something that so far is needed only on very
specific platform. May be we could restrict it to EFI only where size
does not matter that much?

Attached rebased patch (I briefly checked and it still boots on i386-pc
and apparently correctly handles timeouts, but I cannot check other
platforms).

Attachment: pmtimer_tsc_master.diff
Description: Text Data

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]