Re: [PATCH v4 1/2] Add support for SMBIOS3 entry point structures

[David Michael]

On Fri, Aug 21, 2015 at 8:12 AM, Andrei Borzenkov <address@hidden> wrote:
> On Sun, Aug 16, 2015 at 5:26 AM, David Michael <address@hidden> wrote:
>>  grub-core/commands/efi/loadbios.c    | 18 ++++++++++++++---
>
> I am not sure we want to touch it. From what I could gather it had
> been used as workaround for lack of proper EFI support in Linux kernel
> long ago and it is unlikely any system that required it would have
> SMBIOS v3.
>
>>  grub-core/commands/efi/lsefisystab.c |  1 +
>>  grub-core/efiemu/i386/pc/cfgtables.c | 38 
>> ++++++++++++++++++++++++++----------
>
> More or less the same. efiemu is used for (assuming it is still used
> by anyone) for Apple systems only, so unless Apple actually supports
> SMBIOS v3 it is probably better to leave it.

I haven't tried any recent Apple systems, but in my quest to find v3
hardware, I looked at a MacBook Air from a generation or two ago.  It
only supported v2.4.

Do you want an updated patch, or is this usable with those files'
changes deleted?

Thanks.

David