Re: master broken?

[Leif Lindholm]

On Wed, Sep 06, 2017 at 03:13:36PM +0000, Vladimir 'phcoder' Serbinenko wrote:
> On Wed, Sep 6, 2017, 15:43 Leif Lindholm <address@hidden> wrote:
> 
> > This seems to have fixed the "bios" build.
> > But the efi variant (--with-efi) still breaks with
> >
> I tried x86_64-efi and it seems to work. And --with-efi doesn't seem to be
> one of our options. Which exact platform fails?

Sorry, typo - I meant --with-platform=efi

On my amd64 (Debian Stretch), running
git clean -fdx && ./autogen.sh && ./configure --with-platform=efi && make -j40

On commit 1b18d6b0d34872ced6b3dbfc3e7957c80efbcb7a.

There is no definition of MULTIBOOT2_EFI_INITIAL_STATE in my tree, but
there is MULTIBOOT_EFI_INITIAL_STATE.

/
    Leif

> >
> > loader/multiboot.c: In function ‘efi_boot’:
> > loader/multiboot.c:142:47: error: ‘MULTIBOOT2_EFI_INITIAL_STATE’
> > undeclared (first use in this function)
> >     struct grub_relocator_efi_state state_efi =
> > MULTIBOOT2_EFI_INITIAL_STATE;
> >
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > loader/multiboot.c:142:47: note: each undeclared identifier is reported
> > only once for each function it appears in
> > loader/multiboot.c:146:44: error: ‘grub_multiboot_payload_eip’ undeclared
> > (first use in this function)
> >     state_efi.MULTIBOOT_EFI_ENTRY_REGISTER = grub_multiboot_payload_eip;
> >
> >
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > /
> >     Leif
> >
> > On Tue, Sep 05, 2017 at 07:11:32PM +0000, Vladimir 'phcoder' Serbinenko
> > wrote:
> > > Repairing
> > >
> > > On Tue, Sep 5, 2017, 21:11 Leif Lindholm <address@hidden>
> > wrote:
> > >
> > > > Hi,
> > > >
> > > > Preparing a new prerequisite set for the ARM* EFI changes, I find
> > > > myself to test build any of the x86 targets after
> > > >
> > > > 21e4a6fa0 multiboot: disentangle multiboot and multiboot2
> > > >
> > > > Build fails with
> > > > loader/multiboot_mbi2.c:25:29: fatal error: grub/multiboot2.h: No such
> > > > file or directory  #include <grub/multiboot2.h>
> > > >
> > > > For now, I will submit the set rebased to the commit before that.
> > > >
> > > > /
> > > >     Leif
> > > >
> >