grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/8] Move the error logging logic from find_device() to the c


From: Daniel Kiper
Subject: Re: [PATCH 3/8] Move the error logging logic from find_device() to the callee.
Date: Mon, 14 May 2018 20:16:28 +0200
User-agent: Mutt/1.3.28i

On Fri, May 11, 2018 at 09:24:41PM +0200, Goffredo Baroncelli wrote:
> This is a preparatory patch. The callee knows better if this
> error is fatal, or if it exists another available disk.

WRT the subject:
  s/Move the error logging logic from find_device() to the callee./
    Move the error logging from find_device() to its caller/?

And it seems to me that every email's subject should start with "btrfs: ",
e.g. "btrfs: Move the error logging from find_device() to its caller".

s/error is fatal, or if it exists another available disk/
  error is fatal or not, i.e. another disk is available./

Otherwise LGTM.

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]