grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 10/10] fdt: Add device tree file type


From: Leif Lindholm
Subject: Re: [PATCH v3 10/10] fdt: Add device tree file type
Date: Mon, 19 Nov 2018 17:56:36 +0000
User-agent: NeoMutt/20170113 (1.7.2)

On Mon, Nov 19, 2018 at 11:11:09AM +0100, Andreas Schwab wrote:
> On Nov 14 2018, Alexander Graf <address@hidden> wrote:
> 
> > diff --git a/grub-core/loader/efi/fdt.c b/grub-core/loader/efi/fdt.c
> > index a4c6e8036..d8ebe648e 100644
> > --- a/grub-core/loader/efi/fdt.c
> > +++ b/grub-core/loader/efi/fdt.c
> > @@ -123,7 +123,7 @@ grub_cmd_devicetree (grub_command_t cmd __attribute__ 
> > ((unused)),
> >        return GRUB_ERR_NONE;
> >      }
> >  
> > -  dtb = grub_file_open (argv[0]);
> > +  dtb = grub_file_open (argv[0], GRUB_FILE_TYPE_DEVICE_TREE);
> >    if (!dtb)
> >      goto out;
> >  
> 
> Looks like this has been obsoleted by commit dfb1742aab?

Actually, that one does not do anything sensible in
grub-core/commands/efi/shim_lock.c
so that hunk would be worth considering including.

Treating DT and ACPI equally sounds sensible to me.

/
    Leif



reply via email to

[Prev in Thread] Current Thread [Next in Thread]