Re: [PATCH V2 2/3] verifiers: Core TPM support

[Matthew Garrett]

On Tue, Nov 27, 2018 at 8:37 AM Daniel Kiper <address@hidden> wrote:
>
> On Mon, Nov 26, 2018 at 05:00:03PM +1100, Matthew Garrett wrote:
> > The implementation here should work fine with TPM 1.2, so the only
>
> Hmmm... IIRC UEFI interface only supports TPM 2.0. However, there is
> a chance that I am missing something.

There are separate UEFI interfaces for TPM 1.2 and TPM 2.0, but only
UEFI has a spec for TPM 2.0.

> > reason to avoid the UEFI implementation is if it's buggy - but given
> > current versions of Windows will use the TPM by default if it's
> > available, I'd be surprised if there's any significant bugs in the
> > wild. I'm not sure there's a real case where you'd have a TPM on a
> > UEFI system without having working firmware support, and if you don't
> > have the firmware support I don't know how you'd discover the TPM in
> > the first place (eg, if it's on SPI we'd need a full SPI
> > implementation in grub to talk to it)
>
> OK, let's go ahead then. If at some point it come out that we need direct
> communication with TPM then we can add it later.

Cool. I'll fix up the nits and resend.