address@hidden: Re: [PATCH] POTFILES: Don't include gnulib in grub.pot]

[Daniel Kiper]

----- Forwarded message from Daniel Kiper <address@hidden> -----

Date: Mon, 25 Mar 2019 15:29:55 +0100
From: Daniel Kiper <address@hidden>
To: Vladimir 'phcoder' Serbinenko <address@hidden>
Subject: Re: [PATCH] POTFILES: Don't include gnulib in grub.pot
User-Agent: NeoMutt/20170113 (1.7.2)

On Mon, Mar 25, 2019 at 03:22:21PM +0100, Vladimir 'phcoder' Serbinenko wrote:
> On Mon, Mar 25, 2019 at 12:58 PM Daniel Kiper <address@hidden> wrote:
> > Sadly this patch does not look complete. ./grub-core/lib/gnulib is still
> > included. And as Colin pointed out missing SOB.
> This directory still exists, at least in my copy. I didn't spend any
> time figuring out if this is intended or stale. In either case I don't
> want those file to accidently end up in POTFILES

I wanted to say that both ./gnulib and ./grub-core/lib/gnulib should be
excluded from search. Your patch excludes ./gnulib only. IMO this is not
sufficient.

Daniel


----- End forwarded message -----