grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC 1/1] mkimage: revert "Align efi sections on 4k boundary"


From: Jesús Diéguez Fernández
Subject: Re: [RFC 1/1] mkimage: revert "Align efi sections on 4k boundary"
Date: Fri, 19 Apr 2019 21:11:50 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

El 19/4/19 a las 17:32, Julien ROBIN escribió:
> Thanks Heinrich, so I tested with your approach and u-boot.bin.
> 

[...]

> 
> 
> /PS : may be making a summary of all architectures/configurations tests
> tutorials would be useful ? Even if it's just QEMU (it would even be a
> lot of work), and used on new releases or wide changes, or just from
> time to time to see if no accident happened in any recent changes. It
> would also be an awesome tutorial for people starting to deal with grub/
> 

As a complete newbie, I can confirm that this is a real need. I recently
contributed a small modification and didn't know exactly which
compilation options I should enable. I finally used a configuration I
found elsewhere, but that's inconsistent if the official way ignores
some warnings or the other way around, treats all warnings as errors.

I know that recently a travis configuration file was added to test that
GRUB builds fine on different platforms. I think that improving it has
more value than just creating a plain text documentation.

The travis integration requires that the code must be hosted on github
(or setup something like this https://stackoverflow.com/a/49019950 ).
Would it be possible to set a remote copy of GRUB's repository on
github? I mean, not my personal copy, but an official mirror, something
like the linux kernel has.
That would allow anyone to make trivial forks on their github account
that can be tested with travis. To deal with the PR submissions on
github, the kernel has a bot that automatically replies to people (see
this example
https://github.com/torvalds/linux/pull/663#issuecomment-474615610 ).

This way around, the only documentation that should be added to
grub-dev.texi would be this workflow:

Fork from github -> make changes -> validate travis build -> send patch.

Jesus



reply via email to

[Prev in Thread] Current Thread [Next in Thread]