[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] net: break out nested function
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v2] net: break out nested function |
|
Date: |
Wed, 20 May 2020 15:16:41 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, May 19, 2020 at 05:18:11PM +0100, Leif Lindholm wrote:
> On Tue, May 19, 2020 at 17:53:03 +0200, Javier Martinez Canillas wrote:
> > Nested functions are not supported in C, but are permitted as an extension
> > in the GNU C dialect. Commit cb2f15c5448 ("normal/main: Search for specific
> > config files for netboot") added a nested function which caused the build
> > to break when compiling with clang.
> >
> > Break that out into a static helper function to make the code portable
> > again.
>
> Works for me.
> Acked-by: Leif Lindholm <address@hidden>
Reviewed-by: Daniel Kiper <address@hidden>
Daniel