[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/10] luks2: Improve readability in luks2_get_keyslot.
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v3 02/10] luks2: Improve readability in luks2_get_keyslot. |
|
Date: |
Fri, 23 Oct 2020 14:14:52 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Mon, Oct 19, 2020 at 06:09:50PM -0500, Glenn Washburn wrote:
> Introduce new variables keyslot_key, digest_key, and segment_key which
> represent the integer key of the item in the respective associative array
> when looping over the array items. This replaces using a generically
> named variable named "idx" used for all three values. The parameter "i"
> is renamed to "keyslot_idx" and the loop variable "j" is renamed to "i".
> Error messages now distinguish between indexes and keys. The former
> include "index" in the error string, and the later are surrounded in quotes.
I think this patch does too many things in one step. Please do one
rename per patch if possible. Additionally, I think this patch, or
series of the patches, should be before current patch #1.
Daniel
- Re: [PATCH v2 07/10] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt., (continued)
Re: [PATCH v2 00/10] Cryptodisk fixes for v2.06 redux, Patrick Steinhardt, 2020/10/09
[PATCH v3 03/10] luks2: Use more intuitive keyslot key instead of index when naming keyslot., Glenn Washburn, 2020/10/19
Re: [PATCH v3 03/10] luks2: Use more intuitive keyslot key instead of index when naming keyslot., Patrick Steinhardt, 2020/10/23
[PATCH v3 01/10] luks2: Fix use of incorrect index and some grub_error() messages., Glenn Washburn, 2020/10/19
Re: [PATCH v3 01/10] luks2: Fix use of incorrect index and some grub_error() messages., Daniel Kiper, 2020/10/23
Re: [PATCH v3 01/10] luks2: Fix use of incorrect index and some grub_error() messages., Patrick Steinhardt, 2020/10/23
[PATCH v3 07/10] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt., Glenn Washburn, 2020/10/19
Re: [PATCH v3 07/10] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt., Patrick Steinhardt, 2020/10/23
Re: [PATCH v3 07/10] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt., Glenn Washburn, 2020/10/26