[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 6/6] gzio: Fix possible use of uninitialized variable in huft_bui
From: |
Darren Kenny |
Subject: |
[PATCH 6/6] gzio: Fix possible use of uninitialized variable in huft_build() |
Date: |
Tue, 26 Oct 2021 15:02:40 +0000 |
In huft_build() it is possible to reach the for loop where 'r' is being
assigned to 'q[j]' without 'r.v' ever being initialized.
Fixes: CID 314024
Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
---
grub-core/io/gzio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/io/gzio.c b/grub-core/io/gzio.c
index aea86a0a9a92..10156e569c85 100644
--- a/grub-core/io/gzio.c
+++ b/grub-core/io/gzio.c
@@ -447,7 +447,7 @@ huft_build (unsigned *b, /* code lengths in bits (all
assumed <= BMAX) */
int l; /* bits per table (returned in m) */
register unsigned *p; /* pointer into c[], b[], or v[] */
register struct huft *q; /* points to current table */
- struct huft r; /* table entry for structure assignment */
+ struct huft r = {0}; /* table entry for structure assignment */
struct huft *u[BMAX]; /* table stack */
unsigned v[N_MAX]; /* values in order of bit length */
register int w; /* bits before this table == (l * h) */
--
2.27.0
- [PATCH 0/6] Fix some Coverity low-hanging bugs, Darren Kenny, 2021/10/26
- [PATCH 6/6] gzio: Fix possible use of uninitialized variable in huft_build(),
Darren Kenny <=
- [PATCH 3/6] grub-fstest: Fix resource leaks in cmd_cmp(), Darren Kenny, 2021/10/26
- [PATCH 4/6] grub-mkfont: Fix memory leak in write_font_pf2(), Darren Kenny, 2021/10/26
- [PATCH 2/6] grub-mkrescue: Fix memory leak in write_part(), Darren Kenny, 2021/10/26
- [PATCH 1/6] grub-install-common: Fix memory leak in copy_all(), Darren Kenny, 2021/10/26
- [PATCH 5/6] zfs: Fix possible insecure use of chunk size in zap_leaf_array_get(), Darren Kenny, 2021/10/26
- Re: [PATCH 0/6] Fix some Coverity low-hanging bugs, Daniel Kiper, 2021/10/28