Re: [PATCH] cryptodisk: Support encrypted volumes using detached headers on a partition

[brutser]

Hi Daniel! No problem, I will do some more testing end of this week with different setups.

> Van: Daniel Kiper <dkiper@net-space.pl>
> Aan: Glenn Washburn <development@efficientek.com>
> Onderwerp: Re: [PATCH] cryptodisk: Support encrypted volumes using detached headers on a partition
> Datum: 09/08/2022 15:17:59 Europe/Paris
> Cc: grub-devel@gnu.org;
>    brutser@perso.be
>
> On Sun, Aug 07, 2022 at 12:18:52AM -0500, Glenn Washburn wrote:
> > Update the read hook to take into account encrypted volumes on a partition.
> > Grub disk read hooks supply an absolute sector number at which the read is
> > started from. If the encrypted volume is in a partition, the sector number
> > given to the read hook will be offset by the number of the sector at the
> > start of the partition. The read hook then needs to subtract the partition
> > start from the supplied sector to get the correct start sector for the read
> > into the detached header file.
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
>
> brutser, may I add on your behalf:
>   Reported-by: brutser <brutser@perso.be>
>   Tested-by: brutser <brutser@perso.be>
>
> Glenn, thank you for fixing this issue!
>
> Daniel