Re: [PATCH v18 08/25] asn1_test: changes for grub compatibility

[Daniel Kiper]

On Thu, Aug 15, 2024 at 02:49:34PM +0800, Gary Lin wrote:
> On Wed, Aug 14, 2024 at 05:52:14PM +0200, Daniel Kiper wrote:
> > On Fri, Jun 28, 2024 at 04:18:51PM +0800, Gary Lin via Grub-devel wrote:
> > > Do a few things to make asn1 tests compile as part of grub:
> > >
> > > - include asn1_test.h only
> > >
> > > - rename the main functions to the test names
> > >
> > > - remove 'verbose' and the unnecessary printf()
> > >
> > > - print the error messages with grub_printf()
> > >
> > > - return either 0 or 1 to reflect the results of the tests
> > >
> > > - replace the system functions with grub functions, ex: memcmp() ->
> > >   grub_memcmp()
> >
> > When I look at this commit message I think this patch can be split
> > further. OK, the last bullet can stay as is.
> >
> I was struggling on whether to split this patch because this series has
> grown much bigger than I thought. Besides, the coverity issues are all

I am OK with number of patches until it has good justification. I think it
is more important to have the patches split into distinct logical parts.

> about libtasn1. Maybe it's time to break this patch series into two:
> libtasn1 and tpm2, so that we can focus on libtasn1, and then tpm2.

I do not think so. The TPM unlock patches depend on the libtasn1 patches
and the libtasn1 patches alone do make much sense.

Daniel