[Guile-commits] 37/55: Avoid leaking a file descriptor in test-unwind

[Andy Wingo]

wingo pushed a commit to branch master
in repository guile.

commit 08926cdcd092c741f7fac726c70fff8f178daeea
Author: Mike Gran <address@hidden>
Date:   Sat Feb 9 16:39:19 2019 -0800

    Avoid leaking a file descriptor in test-unwind
    
    * test-suite/standalone/test-unwind.c (check_ports): explicitly close temp 
file
---
 test-suite/standalone/test-unwind.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/test-suite/standalone/test-unwind.c 
b/test-suite/standalone/test-unwind.c
index fe10d2d..33752cd 100644
--- a/test-suite/standalone/test-unwind.c
+++ b/test-suite/standalone/test-unwind.c
@@ -1,4 +1,4 @@
-/* Copyright 2004-2005,2008-2010,2013,2018
+/* Copyright 2004-2005,2008-2010,2013,2018-2019
     Free Software Foundation, Inc.
 
    This file is part of Guile.
@@ -201,6 +201,7 @@ check_ports ()
 #define FILENAME_TEMPLATE "/check-ports.XXXXXX"
   char *filename;
   const char *tmpdir = getenv ("TMPDIR");
+  int fd;
 #ifdef __MINGW32__
   extern int mkstemp (char *);
 
@@ -222,8 +223,10 @@ check_ports ()
 
   /* Sanity check: Make sure that `filename' is actually writeable.
      We used to use mktemp(3), but that is now considered a security risk.  */
-  if (0 > mkstemp (filename))
+  fd = mkstemp (filename);
+  if (fd < 0)
     exit (EXIT_FAILURE);
+  close (fd);
 
   scm_dynwind_begin (0);
   {