[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Reference leak in `iprin1 ()'
From: |
Neil Jerram |
Subject: |
Re: [PATCH] Reference leak in `iprin1 ()' |
Date: |
Wed, 16 Nov 2005 21:18:45 +0000 |
User-agent: |
Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> Hello,
>
> Neil Jerram <address@hidden> writes:
>
>> Nice work, but it looks to me that PUSH_REF sets the value of the
>> (pstate->top)th element _before_ incrementing pstate->top. So
>> shouldn't your fix do the decrement first and then set the slot to
>> undefined?
>
> Yes, you're perfectly right.
Thanks. (It's always better to have other people check and agree!)
>> Also, is the () -> (void) change strictly related?
>
> In fact, it's strictly unrelated, but while we're at it (really `(void)'
> was meant here, not `()')...
Why? Does () have any symptoms that we should be concerned about?
> Below is an updated patch. I modified `PUSH_REF ()' as well so that it
> does PSTATE->TOP++ _after_ using the `PSTATE_STACK_SET ()' macro: this
> is safer.
Why is it safer? My inclination is that it's usually safer to change
less code, other things being equal.
> And, well, I couldn't resist the desire to "beautifully
> backslashify" `ENTER_NESTED_DATA ()' as well. :-) I hope this is not
> too much pollution for you.
No, I'm happy to go along with that one!
Regards,
Neil
- Re: [PATCH] Marking weak alist vectors, (continued)
- Re: [PATCH] Marking weak alist vectors, Han-Wen Nienhuys, 2005/11/09
- Re: [PATCH] Marking weak alist vectors, Ludovic Courtès, 2005/11/09
- [PATCH] Reference leak in `iprin1 ()', Ludovic Courtès, 2005/11/10
- Re: [PATCH] Reference leak in `iprin1 ()', Neil Jerram, 2005/11/12
- Re: [PATCH] Reference leak in `iprin1 ()', Ludovic Courtès, 2005/11/14
- Re: [PATCH] Reference leak in `iprin1 ()',
Neil Jerram <=
- Re: [PATCH] Reference leak in `iprin1 ()', Ludovic Courtès, 2005/11/17
- Re: [PATCH] Reference leak in `iprin1 ()', Neil Jerram, 2005/11/17
- Re: [PATCH] Marking weak alist vectors, #2, Ludovic Courtès, 2005/11/23
- Re: [PATCH] Marking weak alist vectors, #2, Han-Wen Nienhuys, 2005/11/23
- Re: [PATCH] Marking weak alist vectors, #2, Ludovic Courtès, 2005/11/24
- Re: [PATCH] Marking weak alist vectors, #2, Kevin Ryde, 2005/11/25
[PATCH] Fixing `gc-live-object-stats', Ludovic Courtès, 2005/11/17