[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: psyntax error reporting bug
From: |
Ludovic Courtès |
Subject: |
Re: psyntax error reporting bug |
Date: |
Sun, 18 Oct 2009 23:41:35 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Hello!
Julian Graham <address@hidden> writes:
> I'm no psyntax expert, but it looks like there's a minor typo in our
> psyntax implementation. In psyntax.scm, at line 1325 (in
> `chi-macro'), the expression:
>
> (syntax-violation #f "encountered raw symbol in macro output"
> (source-wrap e w s mod) x)
>
> ...should read:
>
> (syntax-violation #f "encountered raw symbol in macro output"
> (source-wrap e w (wrap-subst w) mod) x)
>
> ...since `s' is not actually in scope
I actually noticed that when testing ‘-Wunbound-variable’:
ice-9/psyntax-pp.scm:1089:38: warning: possibly unbound variable `s'
But I didn’t take the time to investigate, so I’m glad you did. :-)
> -- which, with the former code, generates an error that obscures the
> actual syntax violation. I can prepare a patch if people want.
Andy is the expert, but I think such a patch can’t hurt, so please do!
Thanks,
Ludo’.