Re: [PATCH] Allow exposing of random number generator state

[Andreas Rottmann]

Andy Wingo <address@hidden> writes:

> On Sun 18 Jul 2010 18:01, Andreas Rottmann <address@hidden> writes:
>
>> Here is a first version of the patch to add an external representation
>> for the RNG state (needed for implementing SRFI 27 "Sources of random
>> bits" in terms of Guile's RNG). I'm not quite sure about the naming of
>> procedures, both one the C and the Scheme side of things -- suggestions
>> highly appreciated!
>
> Great, thanks!
>
> There's something still that doesn't feel quite right about it -- that
> the docs don't define adequately what a seed is, and these 'external'
> values serve a similar purpose -- but oh well. I thought about it for 20
> minutes or so and couldn't think of something better.
>
> I replaced "external" with "datum", in your names. It felt better. Hope
> that's OK.
>
Sure -- seems better to me as well, FWIW.

> In the future would you mind making a few test cases when you submit
> bugfixes or feature patches? It is a pain, but it helps maintain Guile's
> quality through time.
>
OK, I'll add testcases in the future. I've not done so for this and the
other pattch, as the SRFI 27 implementation I'll submit a patch for next
will have tests that (indirectly) excercise the added functionality of
these patches. Testing the features stand-alone would have been better
and yield more self-contained patches, I agree.

Cheers, Rotty
-- 
Andreas Rottmann -- <http://rotty.yi.org/>