[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Creating guild bundles [bug/feature request]
From: |
Andy Wingo |
Subject: |
Re: Creating guild bundles [bug/feature request] |
Date: |
Wed, 04 Jan 2012 13:05:08 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Hi Ian,
Thanks for testing the guildhall! Again, terribly sorry for the delay.
On Sun 04 Sep 2011 08:24, Ian Price <address@hidden> writes:
> $ guild create-bundle
> Creating pfds_0.zip
> $ unzip -l pfds_0.zip
> Archive: pfds_0.zip
> Length Date Time Name
> −−−−−−−−− −−−−−−−−−− −−−−− −−−−
> 2221 09−04−2011 12:41 pfds_0/tests.scm
> 57 09−04−2011 12:41 pfds_0/README
> 380 09−04−2011 12:41 pfds_0/pkg−list.scm
> 2910 09−04−2011 12:41 pfds_0/queues.sls
> −−−−−−−−− −−−−−−−
> 5568 4 files
>
> So far, so good, but a simple 'git init' later.
>
> $ git init
> Initialized empty Git repository in /tmp/pfds/.git/
> $ guild create-bundle
> Creating pfds_0.zip
>
> zip error: Nothing to do! (/tmp/pfds/pfds_0.zip)
>
> The problem is that sigil (well, list-files in (sigil actions)) is being
> clever, and punts to the underlying vcs if there is one, which can lead
> to ill-formed bundles if not all files are under revision control (in my
> particular case, it was pkg-list.scm that was not (yet) added :). Rather
> than using heuristics, I think it would be better to use pkg-list.scm
> itself to decide what to bundle, but I don't think this is a priority,
> as long as people know there are edge cases :).
In the end I think the current behavior is the right thing to do, but
the problem is that the error isn't right. It gives you a big
backtrace, which is unnecessary, and it doesn't tell you that the
directory is under version control, and it should warn if there are no
files.
Andy
--
http://wingolog.org/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Creating guild bundles [bug/feature request],
Andy Wingo <=