[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Universally-unique gensyms
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Universally-unique gensyms |
Date: |
Wed, 18 Jan 2012 23:43:44 +0100 |
User-agent: |
Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux) |
Andy Wingo <address@hidden> skribis:
> On Wed 18 Jan 2012 22:41, address@hidden (Ludovic Courtès) writes:
>
>> Could you stick to GNU-style change logs, describing the change (for
>> example, “New function”), and not the rationale, function, etc.?
>>
>> (Andy might disagree with me, but don’t listen to him. ;-))
>
> FWIW I have grown to agree with you over time, and your chiding, while
> not always well-received in the moment, has made for better commit logs
> :)
Heh. :-) Apologies if this came out as chiding, though.
>>> + static const char base64[GENSYM_RADIX] =
>>> + "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789$@";
>>> + static const char base4[4] = "_.-~";
>>
>> Could we use Gnulib’s ‘base64’ module instead?
>
> FWIW (again) I thought the same initially, but Mark is incrementing a
> base64 buffer instead of continually reencoding a value. It seems OK in
> this instance.
Oh, right, makes sense.
Ludo’.
- [PATCH] Universally-unique gensyms, Mark H Weaver, 2012/01/17
- Re: [PATCH] Universally-unique gensyms, Andy Wingo, 2012/01/17
- Re: [PATCH] Universally-unique gensyms, Andy Wingo, 2012/01/17
- Re: [PATCH] Universally-unique gensyms, Mark H Weaver, 2012/01/18
- Re: [PATCH] Universally-unique gensyms, Mark H Weaver, 2012/01/18
- Re: [PATCH] Universally-unique gensyms, Ludovic Courtès, 2012/01/18
- Re: [PATCH] Universally-unique gensyms, Ludovic Courtès, 2012/01/18
- Re: [PATCH] Universally-unique gensyms, Andy Wingo, 2012/01/18
- Re: [PATCH] Universally-unique gensyms,
Ludovic Courtès <=
- Re: [PATCH] Universally-unique gensyms, Mark H Weaver, 2012/01/18
- Re: [PATCH] Universally-unique gensyms, David Kastrup, 2012/01/18
- Re: [PATCH] Universally-unique gensyms, Mark H Weaver, 2012/01/18
- Re: [PATCH] Universally-unique gensyms, David Kastrup, 2012/01/19
- Re: [PATCH] Universally-unique gensyms, Mark H Weaver, 2012/01/19
- Re: [PATCH] Universally-unique gensyms, Mark H Weaver, 2012/01/19
- Re: [PATCH] Universally-unique gensyms, Mark H Weaver, 2012/01/18
- Re: [PATCH] Universally-unique gensyms, Ludovic Courtès, 2012/01/19