Re: [PATCH] Implement ‘hash’ for structs

[Ludovic Courtès]

Mark H Weaver <address@hidden> skribis:

> address@hidden (Ludovic Courtès) writes:
>
>> Mark H Weaver <address@hidden> skribis:
>>
>>> I guess this 'if' is to avoid an infinite loop if the struct points back
>>> to itself.  However, it apparently fails to detect cycles in the general
>>> case.
>>
>> Yes, indeed.
>>
>> Here’s an updated patch that uses the ‘depth’ argument of ‘scm_hasher’
>> for that, as is done for pairs.
>
> I don't think 'depth' is an appropriate name for that argument.

I’ve finally pushed it (keeping that variable name).

Thanks for the review!

Ludo’.