guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Do not scan for coding declarations in open-file


From: Andy Wingo
Subject: Re: [PATCH] Do not scan for coding declarations in open-file
Date: Thu, 31 Jan 2013 11:00:44 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

On Thu 31 Jan 2013 06:06, Mark H Weaver <address@hidden> writes:

> From: Mark H Weaver <address@hidden>
> Date: Wed, 30 Jan 2013 14:45:28 -0500
> Subject: [PATCH] Do not scan for coding declarations in open-file.

The patch looks good to me but I am concerned about the behavior
change, and that it is inconvenient to get the previous behavior.

My instinct is that we should not merge this patch without including a
way to enable the coding sniff; which seems to mean adding keywords or
somehow extending the arguments of:

  open-file
  with-input-from-file
  with-output-to-file
  call-with-output-file
  call-with-input-file
  open-input-file

Dunno; that is a larger task.  I'd be interested in Ludovic's thoughts
as well.

Andy
-- 
http://wingolog.org/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]