[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Elisp branch ready for merge (??)
From: |
Christopher Allan Webber |
Subject: |
Re: Elisp branch ready for merge (??) |
Date: |
Fri, 11 Mar 2016 08:30:33 -0800 |
User-agent: |
mu4e 0.9.13; emacs 24.5.1 |
Mathieu Lirzin writes:
> Christopher Allan Webber <address@hidden> writes:
>
>> Well, I didn't think I'd have time to do this (and in a sense I didn't)
>> but:
>> https://gitlab.com/dustyweb/guile/tree/merge-bipt-elisp-wip
>>
>> I've rebased the whole branch against git master and added ChangeLog
>> style entries. "make check" is passing. It seems to me that it's ready
>> for merge. I did the best I could on the ChangeLog additions, both with
>> my limited ChangeLog experience and from my limited Guile internals
>> experience. So, corrections welcome, but otherwise...
>
> Nice!
>
> Small nitpick. Could you remove the extra spaces at the start of
> indented lines? :)
>
> I know this practice is/was a common practice in Guile but even if it
> looks prettier with indentation, this is not the proper change log
> format described by GCS and recognized by 'change-log-mode' in Emacs.
I could... but I'm hesitant to do so if it's not the standard ways to do
things in Guile's repository. I'll leave that question to whoever is
interested in merging it. If they'd like me to change it, I'll do it,
and since they have commit access, I consider them the authority.
- Re: What's needed to get elisp updates into Guile master?, (continued)
- Elisp branch ready for merge (??), Christopher Allan Webber, 2016/03/10
- Re: Elisp branch ready for merge (??), Taylan Ulrich Bayırlı/Kammer, 2016/03/11
- Re: Elisp branch ready for merge (??), Christopher Allan Webber, 2016/03/11
- Re: Elisp branch ready for merge (??), Taylan Ulrich Bayırlı/Kammer, 2016/03/12
- Re: Elisp branch ready for merge (??), Christopher Allan Webber, 2016/03/12
- Re: Elisp branch ready for merge (??), Mathieu Lirzin, 2016/03/11
- Re: Elisp branch ready for merge (??),
Christopher Allan Webber <=
- Re: Elisp branch ready for merge (??), Mathieu Lirzin, 2016/03/11
- Re: Elisp branch ready for merge (??), Christopher Allan Webber, 2016/03/25
Re: Guile & Emacs chat at emacs hackathon/bug-crush SF, Mikael Djurfeldt, 2016/03/16