[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Improve reporting of exception locations
|
From: |
Maxime Devos |
|
Subject: |
Re: [PATCH] Improve reporting of exception locations |
|
Date: |
Wed, 21 Sep 2022 12:42:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 |
On 20-09-2022 04:00, Andrew Whatson wrote:
Most errors were reported as coming from boot-9.scm due to incorrect
hard-coded stack-narrowing offsets. This patch fixes the offsets and
adds an argument to specify additional frames to skip when calling
raise-exception.
Do you have some test cases, to
(1) avoid breaking things again with future changes
(2) and show that this patch is correct?
There recent-ish was a bug report about exception handling (on IRC), it
would be a unfortunate if whatever the fix for that turned out to be,
causes the reporting to be wrong again -- a few test cases for this
patch could prevent that.
Greetings,
Maxime.
OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature