[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GNU Guile 3.0.9rc1 available for testing!
From: |
Ludovic Courtès |
Subject: |
Re: GNU Guile 3.0.9rc1 available for testing! |
Date: |
Wed, 25 Jan 2023 11:32:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi Greg,
Greg Troxel <gdt@lexort.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> So something like the patch below?
>>
>> Thanks,
>> Ludo’.
>>
>> diff --git a/libguile/posix.c b/libguile/posix.c
>> index 74c743119..0b1fe2637 100644
>> --- a/libguile/posix.c
>> +++ b/libguile/posix.c
>> @@ -105,8 +105,8 @@
>> # else
>> # define W_EXITCODE(ret, sig) ((ret) << 8 | (sig))
>> # endif
>> -#endif
>> verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127);
>> +#endif
>>
>>
>> #include <signal.h>
>
> I see you pushed that to master and I have done a full build from master
> with the pkgsrc JIT workarounds. It mostly worked and I got this, which
> may be because I purged not-needed packages (but the guile build didn't
> complain at configure or check time, like it did for missing gperf which
> I put back). Or maybe I just haven't gotten this far with 3.0.9-ish.
>
> CC test_foreign_object_c-test-foreign-object-c.o
> CCLD test-foreign-object-c
> ld: ../../libguile/.libs/libguile-3.0.so: warning: warning: tmpnam()
> possibly used unsafely, use mkstemp() or mkdtemp()
> ld: /tmp//ccOnwVqC.ltrans0.ltrans.o: in function `finalizer':
>
> /home/n0/gdt/SOFTWARE/GUILE/guile/BUILD/test-suite/standalone/../../../test-suite/standalone/test-foreign-object-c.c:42:
> undefined reference to `rpl_free'
I believe this is because these C files in test-suite/standalone end up
including Gnulib headers (like <stdlib.h>), which really shouldn’t be
necessary, without linking against libgnu.a.
I believe the patch below fixes that.
[...]
> There are some issues for me to work through eventually, but for 3.0.9 I
> have arrived at being ok with you releasing the current state of git
> master (3 commits past rc1) as not having anything I can claim is a
> regression and not anything I can't work around as before.
Sounds good.
Thanks for your feedback!
Ludo’.
diff --git a/test-suite/standalone/Makefile.am
b/test-suite/standalone/Makefile.am
index 547241afa..0b5d05ddb 100644
--- a/test-suite/standalone/Makefile.am
+++ b/test-suite/standalone/Makefile.am
@@ -1,7 +1,7 @@
## Process this file with automake to produce Makefile.in.
##
## Copyright 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010,
-## 2011, 2012, 2013, 2014, 2020, 2021, 2022 Free Software Foundation, Inc.
+## 2011, 2012, 2013, 2014, 2020, 2021, 2022, 2023 Free Software Foundation,
Inc.
##
## This file is part of GUILE.
##
@@ -39,8 +39,7 @@ TESTS_ENVIRONMENT =
\
## Check for headers in $(srcdir) and build dir before $(CPPFLAGS), which
## may point us to an old, installed version of guile.
-AM_CPPFLAGS = -I$(top_srcdir) -I$(top_builddir) \
- -I$(top_srcdir)/lib -I$(top_builddir)/lib
+AM_CPPFLAGS = -I$(top_srcdir) -I$(top_builddir)
test_cflags = \
-I$(top_srcdir)/test-suite/standalone -I. \
@@ -55,7 +54,7 @@ LIBGUILE_LDADD =
\
snarfcppopts = \
- -I$(top_srcdir) -I$(top_srcdir)/lib -I$(top_builddir)/lib -I$(top_builddir) \
+ -I$(top_srcdir) -I$(top_builddir) \
-I. $(DEFS) $(DEFAULT_INCLUDES) $(CPPFLAGS) $(CFLAGS)
SUFFIXES = .x
- Re: GNU Guile 3.0.9rc1 available for testing!, (continued)
Re: GNU Guile 3.0.9rc1 available for testing!, Greg Troxel, 2023/01/22
Re: GNU Guile 3.0.9rc1 available for testing!, Ludovic Courtès, 2023/01/23
Re: GNU Guile 3.0.9rc1 available for testing!, Greg Troxel, 2023/01/24