[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/6] docs/match: add pattern matching examples
From: |
Maxime Devos |
Subject: |
Re: [PATCH v1 1/6] docs/match: add pattern matching examples |
Date: |
Sun, 29 Jan 2023 15:23:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 |
On 29-01-2023 03:40, Blake Shaw wrote:
Hi Maxime,
Did you watch my talk from Guix days?
I read the text in the talk, but mostly skipped the speech.
There I detailed that the goal
would be to move from what is painfully obvious, gradually building up
in chunks and peices. That is what is happening here.
OK, but I don't see the relevance of this information here.
If you think the
progression of examples that follow are suboptimal in comparison to the
current state of the documentation, then you should give a reason why as
well as offer changes to be made.
I didn't say anything about the progression being good or bad. I wrote:
This is a suboptimal example; this would be better done with 'case'.
I propose replacing it with another example, or adding a note that one
would normally use 'case' for this.
I.e., the example itself is suboptimal; the progression is presumably good.
Also, I did mention a reason why the example is bad: ‘this would be
better done with 'case'’. More explicitly, this example teaches to use
'match' in situations where 'case' would be a better fit.
And I did offer changes to be made: ‘replace it with another example’
(I don't care which exact example it is replaced with, as long as its a
simple example to fit in the progression and something where 'match' is
actually a good fit in order to not teach suboptimal behaviour), and
also gave an alternative, more explicit change 'add a note'.
Greetings,
Maxime.
OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
- Re: [PATCH v1 2/6] docs/match: rm unquote-splicing as it interferes with textinfo, (continued)
[PATCH v1 3/6] docs/match: add reverse nested list example, Blake Shaw, 2023/01/26
[PATCH v1 6/6] docs/match:style reviewing with pdf, adding newlines, Blake Shaw, 2023/01/26
[PATCH v1 4/6] docs/match: match-let* unwrap example, Blake Shaw, 2023/01/26
[PATCH v1 5/6] docs/fixup: @cindex was in the wrong place, Blake Shaw, 2023/01/26
Re: [PATCH v1 1/6] docs/match: add pattern matching examples, Maxime Devos, 2023/01/28
Re: [PATCH v1 1/6] docs/match: add pattern matching examples, Maxime Devos, 2023/01/28
- Message not available
- Re: [PATCH v1 1/6] docs/match: add pattern matching examples, Maxime Devos, 2023/01/29
- Re: [PATCH v1 1/6] docs/match: add pattern matching examples, Blake Shaw, 2023/01/29
- Re: [PATCH v1 1/6] docs/match: add pattern matching examples, Aleix Conchillo Flaqué, 2023/01/30
- Re: [PATCH v1 1/6] docs/match: add pattern matching examples, Aleix Conchillo Flaqué, 2023/01/30
- Re: [PATCH v1 1/6] docs/match: add pattern matching examples, Maxime Devos, 2023/01/30
- Re: [PATCH v1 1/6] docs/match: add pattern matching examples, Aleix Conchillo Flaqué, 2023/01/30
Re: [PATCH v1 1/6] docs/match: add pattern matching examples + CoC, Maxime Devos, 2023/01/30