[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: base: Add glibc-for-target macro.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] gnu: base: Add glibc-for-target macro. |
Date: |
Tue, 07 Jun 2016 15:48:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Manolis Ragkousis <address@hidden> skribis:
> From b19ac63ee9605c4e84c447668c5701bda284114f Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <address@hidden>
> Date: Mon, 6 Jun 2016 17:21:51 +0300
> Subject: [PATCH] gnu: base: Add glibc-for-target macro.
>
> * gnu/packages/base.scm (glibc): Add macro.
> (glibc/linux): Rename glibc to glibc/linux.
> (glibc/hurd): Adjust accordingly.
LGTM, but please double-check that:
./pre-inst-env guix build inkscape -d
is the same both with and without the patch.
> +(define-public glibc/hurd
> + ;; The Hurd's libc variant.
> + (package (inherit glibc/linux)
> + (name "glibc-hurd")
I assume this definition was just moved higher in the file, right?
OK for core-updates, thanks!
Ludo’.