[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Fwd: Re: [Patch] address@hidden
From: |
Ben Woodcroft |
Subject: |
Fwd: Re: [Patch] address@hidden |
Date: |
Thu, 9 Jun 2016 08:57:27 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
This got bounced from the list for being over the attachment size limit,
so sending again with gzipped build.log
On 06/06/16 07:22, Matthew Jordan wrote:
Good Day Ben Woodcroft,
This is what I have so far, although I'm not that familiar with byebug
though. I'll try to dig a bit deeper to get a better understanding of
what's going on.
Thanks for looking into it.
[..]
I had a go at re-enabling tests which were disabled in the original
package - see the attached patch. Unfortunately it is still failing a
few tests. Would you like to take a look into why this might be?
Here a summary of test info. The test
"Byebug::SaveTest#test_save_shows_a_success_message" seems to fail cause
it's looking for a file in a home directory that doesn't exist. Setting
the HOME variable seems to solve that.
Good plan. I'm not sure how you set HOME in your package, but setting it
to /tmp seems to give less errors, though there is still 4 of them.
The first one seems to be due to "File.realpath" returning a form the
test isn't expecting:
e.g. expected;
"--> #0 Byebug::ByebugTest201606081021q3p5qfClass.to_int(str#String)
at
/tmp/nix-build-ruby-byebug-9.0.5.drv-0/byebug_test20160608-102-1q3p5qf.rb:16
observed
"--> #0 Byebug::ByebugTest201606081021q3p5qfClass.to_int(str#String)
at
.../tmp/nix-build-ruby-byebug-9.0.5.drv-0/byebug_test20160608-102-1q3p5qf.rb:16",
This might be fixable by patching line 76 of this file:
https://github.com/deivid-rodriguez/byebug/blob/24ad09b8f84531a7d5b112e6e7932bbc13fb7086/test/support/test_case.rb
I've not had time to look at the other tests, some are the same as the
errors you found. Are you able to take a look please?
Thanks,
ben
0001-gnu-ruby-byebug-Update-to-9.0.5.patch
Description: Text Data
build.log.gz
Description: application/gzip
- Fwd: Re: [Patch] address@hidden,
Ben Woodcroft <=