guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add netcat-openbsd.


From: Leo Famulari
Subject: Re: [PATCH] gnu: Add netcat-openbsd.
Date: Wed, 22 Jun 2016 00:52:23 -0400
User-agent: Mutt/1.6.0 (2016-04-01)

Thank you for this patch!

On Wed, Jun 22, 2016 at 12:07:50AM +0000, ng0 wrote:
> Initially, this could make git throw some trailing
> whitespace problems on the new files in patches dir,
> but they are fixed by git itself.

I think the whitespace warnings about the patches are fine.

> Subject: [PATCH] gnu: Add netcat-openbsd.
> 
> * gnu/packages/admin.scm (netcat-openbsd): New variable.
> * patches/netcat-openbsd-0001-port-to-linux-with-libsd.patch,
> patches/netcat-openbsd-0002-connect-timeout.patch,
> patches/netcat-openbsd-0003-get-sev-by-name.patch,
> patches/netcat-openbsd-0004-poll-hup.patch,
> patches/netcat-openbsd-0005-send-crlf.patch,
> patches/netcat-openbsd-0006-quit-timer.patch,
> patches/netcat-openbsd-0007-udp-scan-timeout.patch,
> patches/netcat-openbsd-0008-verbose-numeric-port.patch,
> patches/netcat-openbsd-0009-dccp-support.patch,
> patches/netcat-openbsd-0010-serialized-handling-multiple-clients.patch,
> patches/netcat-openbsd-0011-misc-failures-and-features.patch: New files.

Can you add a link to the upstream source of the patch in each patch?
I think the links containing Git hashes are best. For example, from the
commit that I think added the patches [0] (they may have been changed
since), you can navigate the tree to the patches directory and copy the
URLs.

[0]
https://anonscm.debian.org/cgit/collab-maint/netcat-openbsd.git/commit/debian?id=db2b1d9a8d4644ef892f47d84606ee96598d23fb



reply via email to

[Prev in Thread] Current Thread [Next in Thread]