guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add chromium-bsu.


From: Alex Kost
Subject: Re: [PATCH] gnu: Add chromium-bsu.
Date: Wed, 22 Jun 2016 11:24:34 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Leo Famulari (2016-06-22 00:44 +0300) wrote:

> On Tue, Jun 21, 2016 at 09:59:31AM -0400, Kei Kebreau wrote:
>> * gnu/packages/games (chromium-bsu): New variable.
>
>> +    (arguments
>> +     `(#:phases (modify-phases %standard-phases
>> +                  (add-after 'set-paths 'set-sdl-paths
>> +                             (lambda* (#:key inputs #:allow-other-keys)
>> +                               (setenv "CPATH"
>> +                                       (string-append (assoc-ref inputs 
>> "sdl-union")
>> +                                                      "/include/SDL"))
>> +                               #t)))))
>
> If you move (modify-phases) underneath #:phases, then this will be
> comfortably shorter than 80 characters :)

I agree with Leo, I would also reformat it like this:

  (arguments
   `(#:phases
     (modify-phases %standard-phases
       (add-after 'set-paths 'set-sdl-paths
         (lambda* (#:key inputs #:allow-other-keys)
           (setenv "CPATH"
                   (string-append (assoc-ref inputs "sdl-union")
                                  "/include/SDL"))
           #t)))))

-- 
Alex



reply via email to

[Prev in Thread] Current Thread [Next in Thread]