[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add python-prompt-toolkit, python2-prompt-toolkit.
From: |
Leo Famulari |
Subject: |
Re: [PATCH] gnu: Add python-prompt-toolkit, python2-prompt-toolkit. |
Date: |
Sat, 25 Jun 2016 14:17:32 -0400 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Wed, Jun 22, 2016 at 03:00:31PM +0200, Danny Milosavljevic wrote:
> * gnu/packages/python.scm (python-prompt-toolkit, python2-prompt-toolkit):
> New variables.
Thanks! Can you rebase the patch on the current master branch? There
have been changes in python.scm and the patch no longer applies.
> +(define-public python-prompt-toolkit
> + (package
> + (name "python-prompt-toolkit")
> + (version "1.0.0")
Why not use the latest release, 1.0.3?
> + (inputs `(("python-six" ,python-six) ; for the tests
Dependencies used only for the test suite should be native-inputs.
> + (synopsis
> + "Library for building powerful interactive command lines in Python")
How about "Library for building command line interfaces in Python"? Or
did I misunderstand the meaning of "command lines"? Either way, we don't
need to describe them as "powerful".
> + (description
> + "Prompt-Toolkit is a library for building powerful interactive command
> lines in Python.
Again, as above?
> + (license bsd-2))) ; FIXME which BSD
Any progress on this?
> +
> +(define-public python2-prompt-toolkit
> + (package
> + (inherit (package-with-python2
> + (strip-python2-variant python-prompt-toolkit)))
> + (native-inputs `(("python2-setuptools" ,python2-setuptools)))))
If python-six becomes a native-input, we'll need to make sure we don't
clobber the inherited native-inputs here. Check python2-orator for an
example.