[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: red-eclipse: Update to 1.5.5.
From: |
Kei Kebreau |
Subject: |
Re: [PATCH] gnu: red-eclipse: Update to 1.5.5. |
Date: |
Mon, 01 Aug 2016 11:43:03 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> writes:
> Hi Kei,
>
>> An important version bump for Red Eclipse, with necessary changes to
>> keep it building properly. I've also included the example server
>> configuration file in the config directory.
>
> thanks for the update.
>
>> + (copy-file "doc/examples/servinit.cfg"
>> + (string-append out "/config/servinit.cfg"))
>
> I think this should not be part of this patch as it doesn’t directly
> relate to the update. Could you please split this?
>
>> * gnu/packages/games.scm (red-eclipse): Update to 1.5.5.
>> (arguments)[phases]: Adjust phases for the red-eclipse update.
>
> The summary should rather be something like this:
>
> * gnu/packages/games.scm (red-eclipse): Update to 1.5.5.
> [arguments]: Adjust phases.
> [inputs]: Use sdl2.
>
> ~~ Ricardo
Thanks for the recommendations. I'll push the patches later with your
changes in mind.
signature.asc
Description: PGP signature