[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix artanis paths
From: |
Mark H Weaver |
Subject: |
Re: [PATCH] Fix artanis paths |
Date: |
Tue, 09 Aug 2016 23:42:37 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Ignacio Torres Masdeu <address@hidden> writes:
> The last patch[1] for artanis added the DESTDIR path to place files in
> $DESTDIR/etc.
>
> [1] http://lists.gnu.org/archive/html/guix-devel/2016-03/msg00813.html
>
> This didn't account for the fact that $DESTDIR is used in the build
> system install process as a prefix for other files and the effect was
> that those files were effectively copied in $out/$out/{bin/share}:
In general, we should be setting PREFIX to $out (i.e. /gnu/store/...),
and leaving DESTDIR unset. Conventionally, these two variables have
different meanings: PREFIX is where the files are expected to be when
the code is run. DESTDIR is meant as a temporary staging area when
building a package, with the expectation that it will be packed up into
a binary package and later extracted into PREFIX. So, with this in
mind:
> + (list (string-append "MOD_PATH=" mod_dir)
> + (string-append "MOD_COMPILED_PATH=" mod_dir)
> + "PREFIX="
> (string-append "DESTDIR=" out)))
I think that this should be (string-append "PREFIX=" out) and DESTDIR
should be left unset.
I haven't looked at the details of this package, or tried to build it,
but I'd like to see a solution that follows the conventions above, if
possible. Would you be willing to try this?
Thanks for your efforts!
Mark