[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add sg3_utils.
From: |
Leo Famulari |
Subject: |
Re: [PATCH] gnu: Add sg3_utils. |
Date: |
Sat, 13 Aug 2016 21:27:43 -0400 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Sat, Aug 13, 2016 at 02:52:56AM -0700, Chris Marusich wrote:
> Chris Marusich <address@hidden> writes:
> Subject: [PATCH] gnu: Add sg3_utils.
>
> * gnu/local.mk: Include gnu/packages/scsi.scm.
> * gnu/packages/scsi.scm: Add new file.
> * gnu/packages/scsi.scm (sg3_utils): New variable.
Thanks for this patch! How about putting it in disk.scm? I have no
strong preference either way. I don't like moving things around too much
once they have been created, however :)
> + #:use-module ((guix licenses)
> + #:select (gpl2+ bsd-3))
Do we need to use #:select here? How about using a license prefix? What
are the pros and cons?
> +(define-public sg3_utils
> + (package
> + (name "sg3_utils")
We like to use underscores instead of hyphens in package names:
https://www.gnu.org/software/guix/manual/html_node/Package-Naming.html#Package-Naming
> + (description
> + "sg3_utils is a collection of utilities for devices that use the Small
> +Computer System Interface (SCSI) command set. It includes utilities to read
> +data from, write data to, control, modify, and query the state of SCSI
> +devices. For example, this package provides command-line tools to copy data
> +based on \"dd\" syntax and semantics (called sg_dd, sgp_dd and sgm_dd), check
> +INQUIRY data and VPD pages (sg_inq), check mode and log pages (sginfo,
> +sg_modes and sg_logs), spin up and down disks (sg_start), do self
> +tests (sg_senddiag), parse sense data, and perform various other functions.
> +In addition, this package includes a library, called libsgutils, which can be
> +used in C and C++ programs to interact with SCSI devices.")
I think that dd, and all the sg_* commands, should be wrapped in texinfo
markup, like this:
@code{dd}
Can you send an updated patch?
signature.asc
Description: PGP signature
- [PATCH] gnu: Add sg3_utils., Chris Marusich, 2016/08/13
- Re: [PATCH] gnu: Add sg3_utils., Chris Marusich, 2016/08/13
- Re: [PATCH] gnu: Add sg3_utils.,
Leo Famulari <=
- Re: [PATCH] gnu: Add sg3_utils., Chris Marusich, 2016/08/13
- Re: [PATCH] gnu: Add sg3_utils., Leo Famulari, 2016/08/14
- Re: [PATCH] gnu: Add sg3_utils., Chris Marusich, 2016/08/14
- Re: [PATCH] gnu: Add sg3_utils., Leo Famulari, 2016/08/14
- Re: [PATCH] gnu: Add sg3_utils., Chris Marusich, 2016/08/14
Re: [PATCH] gnu: Add sg3_utils., Leo Famulari, 2016/08/13