Re: [PATCH 0/7] Add Prosody

[Leo Famulari]

On Mon, Aug 22, 2016 at 09:39:11PM +0200, Ricardo Wurmus wrote:
> Hi Guix,
> 
> this patch series adds a package for the XMPP server Prosody.
> 
> The first patch is needed to allow Lua to load dynamic libraries via dlopen.
> 
> I'm not sure about the naming.  Prosody needs Lua 5.1, so I didn't even
> attempt to build the Lua packages for any later version.  The variable names
> all have a "lua5.1-" prefix, but the packages themselves don't; should they?

I'm not sure either; I think this is fine.

I found the commit messages a little confusing, especially the luasec
commit. It adds "luasec", but there is no package name or variable
called "luasec". I know that the upstream package name is "LuaSec". A
very minor quibble...

> 
> ~~ Ricardo
> 
> Ricardo Wurmus (7):
>   gnu: lua: Build with support for dynamic libraries.
>   gnu: lua: Use "license:" prefix.
>   gnu: Add lua5.1-expat.
>   gnu: Add lua5.1-socket.
>   gnu: Add lua5.1-filesystem.
>   gnu: Add luasec.
>   gnu: Add prosody.
> 
>  gnu/packages/lua.scm       | 168 
> ++++++++++++++++++++++++++++++++++++++++++---
>  gnu/packages/messaging.scm |  78 ++++++++++++++++++++-
>  2 files changed, 236 insertions(+), 10 deletions(-)
> 
> -- 
> 2.9.2
> 
> 
>