[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Remove trademark acknowledgements.
From: |
Eric Bavier |
Subject: |
Re: [PATCH] gnu: Remove trademark acknowledgements. |
Date: |
Tue, 23 Aug 2016 10:31:09 -0500 |
On Tue, 23 Aug 2016 12:15:17 +0200
Ricardo Wurmus <address@hidden> wrote:
> Eric Bavier <address@hidden> writes:
>
> > On Mon, 22 Aug 2016 22:03:58 +0200
> > Ricardo Wurmus <address@hidden> wrote:
> >
> >> John Darrington <address@hidden> writes:
> >>
> >> > These somehow crept in, but are an explicit violation of GNU policy and
> >> > coding standards.
> >>
> >> Good catch! Thanks for fixing this.
> >>
> >> ~~ Ricardo
> >
> > How about the attached patch to catch such things earlier?
>
> I like it. Thanks, Eric!
>
> Not sure if we should use “for-each” here (going through the string
> once for each character) or if we could just go through the string once,
> checking for any character match.
>
> Also, should we replace “sign” with “character”?
In this updated patch I addressed both of these concerns. It's also
about 14% faster (on a single benchmark :).
`~Eric
0001-guix-lint-Check-descriptions-for-trademark-signs.patch
Description: Text Data
Re: [PATCH] gnu: Remove trademark acknowledgements., Leo Famulari, 2016/08/22