Re: [PATCH] gnu: rofi: Update to 1.2.0.

[Leo Famulari]

On Wed, Aug 31, 2016 at 04:00:06PM +0100, Marius Bakke wrote:
> Greetings Guix,
> 
> I am the maintainer of this package in NixOS and figured I could update
> it here as well, since it was non-trivial.

Thanks!

> The libx11 dependency is dropped in favour of a new xcb-util-xrm module.
> I added the latter to xdisorg since it's not listed on xcb.fd.o proper,
> but followed the convention of the other xcb-util-* libraries.
> 
> Disclaimer: untested, apart from building with rounds=2.

Okay!

> Subject: [PATCH 1/2] gnu: Add xcb-util-xrm.
> 
> * gnu/packages/xdisorg.scm (xcb-util-xrm): New variable.

This actually bundles m4, even if it doesn't use it. Can you delete that
'm4' directory in an origin snippet? There's an example in the calibre
package definition.

> +              (uri (string-append
> +                    
> "https://github.com/Airblader/xcb-util-xrm/releases/download";

Also this line a bit too long :)

Otherwise LGTM!