Re: Web interface review

[Tatiana Sholokhova]

Hello Clément!

Thank you for your review!

I fixed most of the problems you noticed and rebased commits as you advised. 

I couldn't fix the problem with several calling of (with-critical-section). As I wrote to IRC channel, I tried to put '(with-critical-section db-channel (db)' around '(let* ...)' and I received an error:

```

   In web/server.scm:

   279:25  0 (_)

Throw to key `vm-error' with args `(vm-run "Too few values returned to continuation" ())'.

```

Could you give a status about the pagination?

Pagination works correctly with evaluations, but it doesn't work correctly with builds. In some cases, we have builds missing. It happens due to equal timestamp values, so we need to filter build by (timestamp, id) tuple key.

What else do we need to do before the merge?

Best regards,

Tatiana

пт, 20 июл. 2018 г. в 11:28, Clément Lassieur <address@hidden>:

Gábor Boskovits <address@hidden> writes:

> Thanks for all of you! Great work.
> As far as I can see most of the suggestions are on style. Do you think that
> we need some improvement in the documentation regarding style, both coding
> and
> documentation?

I don't know, but I think encouraging people to copy the existing style
is a good starting point. :-)